Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Tightening `#sound-dai-cells` to `const: 1` breaks `make dtbs_check` validation for existing in-tree device trees. --
--- Patch [20]: [PATCH v10 20/21] dt-bindings: display: rockchip: dw-dp: Fix sound DAI cells --- commit b5cf5d4b2be1635b36333fe2b9b6e821a83fdf42 Author: Sebastian Reichel <[email protected]> dt-bindings: display: rockchip: dw-dp: Fix sound DAI cells This commit updates the Rockchip DesignWare DisplayPort controller binding to change #sound-dai-cells from 0 to 1, adding an argument to select between I2S and S/PDIF interfaces. > diff --git > a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-dp.yaml > b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-dp.yaml > index 2b0d9e23e9432..c4f8959dd65da 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-dp.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-dp.yaml [ ... ] > @@ -83,7 +83,8 @@ properties: > maxItems: 1 > > "#sound-dai-cells": > - const: 0 > + const: 1 [Severity: Medium] Will tightening this to const: 1 break make dtbs_check validation for existing in-tree device trees? The unmodified in-tree .dtsi files continue to use <0>, which violates the newly introduced strict constraint. For example, in arch/arm64/boot/dts/rockchip/rk3588-base.dtsi for dp0: #sound-dai-cells = <0>; While this affects the device tree build and validation process, it does not impact runtime functionality since no driver currently consumes this DAI. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/20260806-synopsys-dw-dp-improvements-v10-0-d84a26c30...@collabora.com?part=20
