Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Replacing `select` with `depends on` silently breaks `socrates_defconfig` and hides the Lime GDC driver. --
--- Patch [1]: [PATCH v2] fbdev: replace dead select with dependency --- commit bd0c1c5dd1e0309a476de7f3f80441e35d1d6474 Author: Julian Braha <[email protected]> fbdev: replace dead select with dependency This commit modifies the Kconfig dependencies for the Fujitsu Lime GDC framebuffer driver. It replaces the select statements for foreign and little endian support with a direct dependency on either little endian or both endians. Link: https://lore.kernel.org/all/[email protected]/ > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > index 085d3a202148b..e8cd8cb76874b 100644 > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -1717,8 +1717,7 @@ config FB_MB862XX_PCI_GDC > config FB_MB862XX_LIME > bool "Lime GDC" > depends on OF && PPC > - select FB_FOREIGN_ENDIAN > - select FB_LITTLE_ENDIAN > + depends on FB_LITTLE_ENDIAN || FB_BOTH_ENDIAN [Severity: Medium] Will this change cause the driver to be silently dropped in socrates_defconfig? Looking at drivers/video/fbdev/core/Kconfig, FB_FOREIGN_ENDIAN defaults to 'n' and gates the endianness choice block: menuconfig FB_FOREIGN_ENDIAN bool "Framebuffer foreign endianness support" depends on FB Since arch/powerpc/configs/85xx/socrates_defconfig requests CONFIG_FB_MB862XX_LIME=y but does not explicitly set CONFIG_FB_FOREIGN_ENDIAN=y, removing the select statement means FB_FOREIGN_ENDIAN will now evaluate to 'n'. This hides the endianness choice block, forcing both FB_LITTLE_ENDIAN and FB_BOTH_ENDIAN to 'n'. Does this mean the new dependency will be unmet, causing the Lime GDC driver to be dropped during defconfig generation despite the commit message indicating this avoids breaking defconfig? > help > Framebuffer support for Fujitsu Lime GDC on host CPU bus. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
