Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Schema validation bypass for numbered endpoint nodes. --
--- Patch [1]: [PATCH v2 1/4] dt-bindings: lcdif: Add endpoint bus-width property --- commit 73f976bb84f0f0a26cb8385791e8483235c1fe74 Author: Francesco Dolcini <[email protected]> dt-bindings: lcdif: Add endpoint bus-width property The DPI output of the LCD interface can be configured with a bus width of 16, 18, or 24 bits. Introduce a bus-width property to the output endpoint, specifying the number of parallel RGB bits connected. > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > index 2dd0411ec6516..6931f0ae38297 100644 > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > @@ -71,6 +71,15 @@ properties: > $ref: /schemas/graph.yaml#/properties/port > description: The LCDIF output port > > + properties: > + endpoint: [Severity: Low] Will this schema validate device trees with multiple endpoints correctly? Defining `endpoint:` under `properties` will only match nodes exactly named "endpoint". Any numbered endpoints like "endpoint@1" or "endpoint@2" will silently bypass these constraints and the `unevaluatedProperties: false` check. Should this be defined using `patternProperties: "^endpoint(@[0-9a-f]+)?$":` instead to ensure the rules apply to all endpoint nodes? > + $ref: /schemas/graph.yaml#/$defs/endpoint-base > + unevaluatedProperties: false > + > + properties: > + bus-width: > + enum: [ 16, 18, 24 ] > + -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
