Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] DRM_XE unconditionally selects TRANSPARENT_HUGEPAGE without inheriting its architecture and PREEMPT_RT dependencies. --
--- Patch [2]: [PATCH 2/3] drm/xe: select TRANSPARENT_HUGEPAGE --- commit 039323cec9a41618d3b6161e1831b08e7ba4069a Author: Matthew Brost <[email protected]> drm/xe: select TRANSPARENT_HUGEPAGE This commit selects TRANSPARENT_HUGEPAGE for the DRM_XE driver to ensure the THP split machinery is available for Xe's TTM shrinker incremental swap path. > diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig > index 4d7dcaff2b915..88a4f3d09d5fe 100644 > --- a/drivers/gpu/drm/xe/Kconfig > +++ b/drivers/gpu/drm/xe/Kconfig > @@ -11,6 +11,12 @@ config DRM_XE > # the shmem_readpage() which depends upon tmpfs > select SHMEM > select TMPFS > + # Xe is the only TTM driver that exercises the TTM shrinker's > + # incremental swap path, which splits the pool's compound folios one > + # page at a time via folio_split_driver_managed(). That helper lives > + # in the THP split machinery, so pull it in here rather than for all > + # TTM users. > + select TRANSPARENT_HUGEPAGE [Severity: Low] Does this select statement need to inherit the dependencies for TRANSPARENT_HUGEPAGE? TRANSPARENT_HUGEPAGE has specific architecture dependencies (like HAVE_ARCH_TRANSPARENT_HUGEPAGE) and can conflict with PREEMPT_RT. Selecting a config symbol without inheriting its dependencies can cause Kconfig unmet dependency warnings and potential build failures on configurations where those dependencies are not met (for example, on non-x86 architectures when building with COMPILE_TEST). Should this use a conditional selection (e.g., select TRANSPARENT_HUGEPAGE if HAVE_ARCH_TRANSPARENT_HUGEPAGE) or be changed to a "depends on" to ensure it is only pulled in when its requirements are satisfied? > select DRM_BUDDY > select DRM_CLIENT_SELECTION > select DRM_KMS_HELPER -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
