ipu_plane_duplicate_state() could dereference NULL when kmalloc() fails
by returning &state->base unconditionally.
Return NULL on allocation failure, as the CRTC duplicate helper does.
Fixes: 00514e859335 ("drm/imx: use PRG/PRE when possible")
Cc: [email protected]
Signed-off-by: Osama Abdelkader <[email protected]>
---
v2:
- add Fixes and Cc tags
---
drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c
b/drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c
index c7ec09e557c1..67f2da7f2b65 100644
--- a/drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c
+++ b/drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c
@@ -323,9 +323,10 @@ ipu_plane_duplicate_state(struct drm_plane *plane)
return NULL;
state = kmalloc_obj(*state);
- if (state)
- __drm_atomic_helper_plane_duplicate_state(plane, &state->base);
+ if (!state)
+ return NULL;
+ __drm_atomic_helper_plane_duplicate_state(plane, &state->base);
return &state->base;
}
--
2.43.0
