Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Incorrect use of `additionalProperties: false` instead of `unevaluatedProperties: false` in a schema containing an `allOf` reference. --
commit 40b975ec362c58607cb7c58d87a808388df1aa11 Author: Pengyu Luo <[email protected]> dt-bindings: display: panel: Add Novatek NT36536 This commit adds a new devicetree binding schema for the Novatek NT36536 DSI panel IC, which supports video mode panels like the dual-link 10-bit CSOT PP8807HB1-1. > diff --git > a/Documentation/devicetree/bindings/display/panel/novatek,nt36536.yaml > b/Documentation/devicetree/bindings/display/panel/novatek,nt36536.yaml > new file mode 100644 > index 0000000000000..1e86f5329b222 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36536.yaml [ ... ] > +allOf: > + - $ref: panel-common-dual.yaml# > + > +properties: [ ... ] > + vsn-supply: > + description: Negative source voltage rail > + > + backlight: true > + ports: true [Severity: Low] Should these properties be omitted? They are already defined in the referenced common schemas and appear to be redundantly redefined here solely because of how additionalProperties is evaluated below. > + > +required: > + - compatible > + - reg > + - vddio-supply > + - reset-gpios > + - ports > + > +additionalProperties: false [Severity: Low] Does this directive incorrectly restrict the schema since there is an allOf reference above? Using additionalProperties: false will cause dtbs_check to reject valid board configurations that use standard panel properties defined in panel-common-dual.yaml and panel-common.yaml (such as rotation or width-mm). Should this be changed to unevaluatedProperties: false instead? Once that is corrected, the redundant backlight and ports entries above can likely be removed. -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
