Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] A moved comment describes operations that are not performed in its new location. --
Note: The format of this report has been altered to provide a free-form summary without direct code quotes due to recitation restrictions. commit 80b1922edca70f8edc78748fddf0120eb2612fec Author: José Expósito <[email protected]> Subject: drm/tests: shmem: Set DMA mask to 64-bit in drm_gem_shmem This commit fixes intermittent DMA address overflow failures on ppc64le and s390x CI systems during drm_gem_shmem tests. It does this by moving the configuration of the 64-bit DMA mask into the test initialization phase, ensuring it applies to all tests rather than just one. Link: https://s3.amazonaws.com/arr-cki-prod-trusted-artifacts/trusted-artifacts/2643976103/test_s390x/15128551935/artifacts/jobwatch/logs/recipes/21561049/tasks/220716793/results/1014626315/logs/dmesg.log Link: https://s3.amazonaws.com/arr-cki-prod-trusted-artifacts/trusted-artifacts/2643976103/test_ppc64le/15128551933/artifacts/jobwatch/logs/recipes/21561041/tasks/220716705/results/1014628163/logs/dmesg.log In drivers/gpu/drm/tests/drm_gem_shmem_test.c: [Severity: Low] This isn't a bug, but does the moved comment in drm_gem_shmem_test_init need to be updated? The patch moves a block comment alongside the dma_set_mask call into the test initialization function. This comment explicitly states "and map the sgtables otherwise drm_gem_shmem_free will cause a warning". However, the actual dma_map_sgtable call was not moved and remains in the original function. Leaving this text in the new location is slightly misleading, as it implies the sgtables are being mapped during device init. Could we update the comment to remove the reference to mapping the sgtables? -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
