Thank you for your contribution! Sashiko AI review found 1 potential issue(s) 
to consider:
- [Medium] The commit message claims to add 'CONFIG_HUGETLBFS=y' to 
'drivers/net/hw/config', but this file modification is missing from the patch.
--

commit c7b1ce8ddda374f6cdcda3fac83aafea966343ab
Author: Bobby Eshleman <[email protected]>

selftests/net: ncdevmem: add -b option to set rx-buf-size on bind

This commit adds a -b <bytes> option to request a non-default niov size via
NETDEV_A_DMABUF_RX_BUF_SIZE. When the value exceeds PAGE_SIZE, it switches 
to a hugetlb-backed memfd to produce naturally-aligned sg entries.

> Add CONFIG_HUGETLBFS=y to drivers/net/hw/config so the new path is
> reachable in the CI kernels built for these tests.

[Severity: Medium]
Is the commit message out of sync with the actual patch? 

The message explicitly states that CONFIG_HUGETLBFS=y is being added to 
tools/testing/selftests/drivers/net/hw/config, but this file modification is
completely missing from the patch.

-- 
Sashiko AI review ยท 
https://sashiko.dev/#/patchset/[email protected]?part=2

Reply via email to