Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The test cases introduced in this patch reference `dummy_hdmi_funcs_scrambler`, which is undeclared in this commit, causing a compilation error. Each patch in a series must compile independently to preserve git bisectability. --
commit 00f793137805b36c4e39a000783f65bb290b345b Author: Cristian Ciocaltea <[email protected]> drm/tests: connector: Add HDMI caps-based init coverage Add KUnit tests for drmm_connector_hdmi_init_with_caps() covering NULL caps rejection, max_tmds_char_rate inference, and limits validation. > diff --git a/drivers/gpu/drm/tests/drm_connector_test.c > b/drivers/gpu/drm/tests/drm_connector_test.c > index beb1d50a66464..1fb1d83aec1af 100644 > --- a/drivers/gpu/drm/tests/drm_connector_test.c > +++ b/drivers/gpu/drm/tests/drm_connector_test.c [ ... ] > +static void drm_test_connector_hdmi_init_max_tmds_rate_inferred(struct kunit > *test) > +{ [ ... ] > + ret = drmm_connector_hdmi_init_with_caps(&priv->drm, &priv->connector, > + "Vendor", "Product", > + &dummy_funcs, > + &dummy_hdmi_funcs_scrambler, [Severity: Low] Does this cause a compilation error? It appears dummy_hdmi_funcs_scrambler is undeclared in this commit. While this gets fixed later in the series in commit c237a4e2c8cf9600c005 (drm/tests: connector: Add HDMI source-side scrambler coverage), referencing it early breaks git bisectability as this patch will fail to compile on its own. This same undeclared variable is also referenced in drm_test_connector_hdmi_init_max_tmds_rate_override() and drm_test_connector_hdmi_init_max_tmds_rate_at_limit() later in this patch. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=32
