Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The kernel-doc for drmm_connector_hdmi_init_with_caps incorrectly claims the caps parameter is optional, but the implementation strictly requires it. --
commit 0bf3f9f06453c1934cf1bf6f51eb321720ded5eb Author: Cristian Ciocaltea <[email protected]> drm/connector: Add caps-based HDMI connector init helper In preparation for adding HDMI 2.x source capabilities, introduce struct drm_connector_hdmi_caps and a new drmm_connector_hdmi_init_with_caps() helper. > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > index 8b4baed060f3a..c7ce6b7bd8b0e 100644 > --- a/drivers/gpu/drm/drm_connector.c > +++ b/drivers/gpu/drm/drm_connector.c [ ... ] > @@ -552,8 +552,7 @@ EXPORT_SYMBOL(drmm_connector_init); > * @hdmi_funcs: HDMI-related callbacks for this connector > * @connector_type: user visible type of the connector > * @ddc: optional pointer to the associated ddc adapter > - * @supported_formats: Bitmask of @drm_output_color_format listing supported > output formats > - * @max_bpc: Maximum bits per char the HDMI connector supports > + * @caps: optional HDMI connector capabilities > * > * Initialises a preallocated HDMI connector. Connectors can be [ ... ] > @@ -591,13 +589,18 @@ int drmm_connector_hdmi_init(struct drm_device *dev, > connector_type == DRM_MODE_CONNECTOR_HDMIB)) > return -EINVAL; > > - if (!supported_formats || !(supported_formats & > BIT(DRM_OUTPUT_COLOR_FORMAT_RGB444))) > + if (!caps) > return -EINVAL; [Severity: Low] The kernel-doc for drmm_connector_hdmi_init_with_caps() marks @caps as an optional parameter, but the implementation explicitly rejects a NULL caps pointer with -EINVAL. Should the documentation be updated to reflect that @caps is actually required? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
