Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The panel's compatible property is missing the mandatory generic fallback string. --
commit 14ab3e4951175e1cf33309cf294f421f36606cd0 Author: Cristian Cozzolino <[email protected]> arm64: dts: qcom: msm8953-flipkart-rimob: Enable display and GPU This commit adds the description for the display panel found on the phone. It also enables the GPU and sets the zap shader firmware path. > diff --git a/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts > b/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts > index ef4faf7631327..5a9d71d1e4664 100644 > --- a/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts > +++ b/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts [ ... ] > @@ -87,11 +94,70 @@ &hsusb_phy { > status = "okay"; > }; > [ ... ] > +&mdss_dsi0 { > + vdda-supply = <&pm8953_s3>; > + vddio-supply = <&pm8953_l6>; > + > + status = "okay"; > + > + panel: panel@0 { > + compatible = "flipkart,rimob-panel-nt35532-cs"; [Severity: Low] Is the generic fallback string missing from this compatible property? The DT schema for this panel (novatek,nt35532.yaml) strictly requires two items for the compatible property: the device-specific string and the generic fallback "novatek,nt35532". Providing only the device-specific string violates the binding and will trigger a dtbs_check warning. > + reg = <0>; > + > + backlight = <&pmi8950_wled>; > + reset-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>; > + avdd-supply = <&lab>; > + avee-supply = <&ibb>; > + vci-supply = <&pm8953_l17>; > + vddi-supply = <&pm8953_l6>; -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
