Re: [PATCH 05/10] drm/sched: use dma_fence_test_signaled_flag()

[Tvrtko Ursulin]

On 24/06/2026 12:13, Christian König wrote:

Instead of dma_fence_is_signaled_locked() use
dma_fence_test_signaled_flag().

No functional difference the mock HW fence has no signaled callback
anyway.

Signed-off-by: Christian König <christian.koe...@amd.com>
---
  drivers/gpu/drm/scheduler/tests/mock_scheduler.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/scheduler/tests/mock_scheduler.c 
b/drivers/gpu/drm/scheduler/tests/mock_scheduler.c
index 14403a762335..82dce344bfa1 100644
--- a/drivers/gpu/drm/scheduler/tests/mock_scheduler.c
+++ b/drivers/gpu/drm/scheduler/tests/mock_scheduler.c
@@ -224,7 +224,7 @@ mock_sched_timedout_job(struct drm_sched_job *sched_job)
        }

spin_lock_irqsave(&sched->lock, flags);

-       if (!dma_fence_is_signaled_locked(&job->hw_fence)) {
+       if (!dma_fence_test_signaled_flag(&job->hw_fence)) {
                list_del(&job->link);
                job->flags |= DRM_MOCK_SCHED_JOB_TIMEDOUT;
                dma_fence_set_error(&job->hw_fence, -ETIMEDOUT);
@@ -258,7 +258,7 @@ static void mock_sched_cancel_job(struct drm_sched_job 
*sched_job)
        hrtimer_cancel(&job->timer);

spin_lock_irqsave(&sched->lock, flags);

-       if (!dma_fence_is_signaled_locked(&job->hw_fence)) {
+       if (!dma_fence_test_signaled_flag(&job->hw_fence)) {
                list_del(&job->link);
                dma_fence_set_error(&job->hw_fence, -ECANCELED);
                dma_fence_signal_locked(&job->hw_fence);

Reviewed-by: Tvrtko Ursulin <tvrtko.ursu...@igalia.com>

Regards,

Tvrtko