On Tue, 30 Jun 2026, Thomas Zimmermann <[email protected]> wrote: > Am 30.06.26 um 12:57 schrieb Jani Nikula: >> On Tue, 30 Jun 2026, Thomas Zimmermann <[email protected]> wrote: >>> Am 15.06.26 um 17:29 schrieb Jani Nikula: >>>> drm_ras.h uses u32. Include linux/types.h for it. >>>> >>>> Signed-off-by: Jani Nikula <[email protected]> >>> Reviewed-by: Thomas Zimmermann <[email protected]> >>> >>> with the question below answered >>> >>>> --- >>>> include/drm/drm_ras.h | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/include/drm/drm_ras.h b/include/drm/drm_ras.h >>>> index f2a787bc4f64..0beede3ddc4e 100644 >>>> --- a/include/drm/drm_ras.h >>>> +++ b/include/drm/drm_ras.h >>>> @@ -6,6 +6,8 @@ >>>> #ifndef __DRM_RAS_H__ >>>> #define __DRM_RAS_H__ >>>> >>>> +#include <linux/types.h> >>>> + >>>> #include <uapi/drm/drm_ras.h> >>> Should the uapi header be included first? That's what I've seen >>> elsewhere and what seems more correct. >> I'm not sure. I just pretty much always put linux includes before any >> drm includes, and I don't think the order should matter functionally. If >> it does, something else is wrong. > > Well, OK then. R-b: me.
Thanks, pushed to drm-misc-fixes. BR, Jani. > >> >> BR, >> Jani. >> >> >>> Best regards >>> Thomas >>> >>>> >>>> /** -- Jani Nikula, Intel
