Bridges have some fields in their state worth printing, but we don't provide an atomic_print_state implementation to show those fields.
Provide one. Reviewed-by: Laurent Pinchart <[email protected]> Signed-off-by: Maxime Ripard <[email protected]> --- drivers/gpu/drm/drm_bridge.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index b7b0ec7c2d4b..e6f1174be62a 100644 --- a/drivers/gpu/drm/drm_bridge.c +++ b/drivers/gpu/drm/drm_bridge.c @@ -548,14 +548,35 @@ drm_bridge_atomic_create_priv_state(struct drm_private_obj *obj) return ERR_CAST(state); return &state->base; } +static void +drm_bridge_atomic_print_priv_state(struct drm_printer *p, + const struct drm_private_state *s) +{ + const struct drm_bridge_state *state = drm_priv_to_bridge_state(s); + struct drm_bridge *bridge = drm_priv_to_bridge(s->obj); + + if (bridge->of_node) + drm_printf(p, "bridge: %ps (%pOFfc)\n", bridge->funcs, bridge->of_node); + else + drm_printf(p, "bridge: %ps\n", bridge->funcs); + + drm_printf_indent(p, 1, "input bus configuration:"); + drm_printf_indent(p, 2, "code: %04x", state->input_bus_cfg.format); + drm_printf_indent(p, 2, "flags: %08x", state->input_bus_cfg.flags); + drm_printf_indent(p, 1, "output bus configuration:"); + drm_printf_indent(p, 2, "code: %04x", state->output_bus_cfg.format); + drm_printf_indent(p, 2, "flags: %08x", state->output_bus_cfg.flags); +} + static const struct drm_private_state_funcs drm_bridge_priv_state_funcs = { .atomic_create_state = drm_bridge_atomic_create_priv_state, .atomic_duplicate_state = drm_bridge_atomic_duplicate_priv_state, .atomic_destroy_state = drm_bridge_atomic_destroy_priv_state, + .atomic_print_state = drm_bridge_atomic_print_priv_state, }; /** * drm_private_obj_is_bridge - check if a private object backs a bridge * @obj: private object to check -- 2.54.0
