On Thu, Jun 25, 2026 at 02:40:34PM +0200, Boris Brezillon wrote: > panthor_fw_unplug() is only called if we at least managed to initialize > the IRQ, so it's safe to drop the "is IRQ initialized" check. > > Signed-off-by: Boris Brezillon <[email protected]>
Reviewed-by: Liviu Dudau <[email protected]> Best regards, Liviu > --- > drivers/gpu/drm/panthor/panthor_fw.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_fw.c > b/drivers/gpu/drm/panthor/panthor_fw.c > index 986151681b24..4fbddb9e18c8 100644 > --- a/drivers/gpu/drm/panthor/panthor_fw.c > +++ b/drivers/gpu/drm/panthor/panthor_fw.c > @@ -1279,9 +1279,7 @@ void panthor_fw_unplug(struct panthor_device *ptdev) > > if (!IS_ENABLED(CONFIG_PM) || pm_runtime_active(ptdev->base.dev)) { > /* Make sure the IRQ handler cannot be called after that point. > */ > - if (ptdev->fw->irq.irq) > - panthor_job_irq_suspend(&ptdev->fw->irq); > - > + panthor_job_irq_suspend(&ptdev->fw->irq); > panthor_fw_stop(ptdev); > } > > > -- > 2.54.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯
