W dniu 26 marca 2011 16:38 u?ytkownik Rafa? Mi?ecki <zajec5 at gmail.com>
napisa?:
> 2011/3/23 Thomas Renninger <trenn at suse.de>:
>> drm radeon: Return -EINVAL on wrong pm sysfs access
>>
>> Throw an error if someone tries to fill this with
>> wrong data, instead of simply ignoring the input.
>> Now you get:
>>
>> echo hello >/sys/../power_method
>> -bash: echo: write error: Invalid argument
>>
>> Signed-off-by: Thomas Renninger <trenn at suse.de>
>> CC: Alexander.Deucher at amd.com
>> CC: dri-devel at lists.freedesktop.org
>>
>> ---
>> ?drivers/gpu/drm/radeon/radeon_pm.c | ? ?8 +++++---
>> ?1 files changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_pm.c
>> b/drivers/gpu/drm/radeon/radeon_pm.c
>> index 2aed03b..08de669 100644
>> --- a/drivers/gpu/drm/radeon/radeon_pm.c
>> +++ b/drivers/gpu/drm/radeon/radeon_pm.c
>> @@ -365,12 +365,14 @@ static ssize_t radeon_set_pm_profile(struct device
>> *dev,
>> ? ? ? ? ? ? ? ?else if (strncmp("high", buf, strlen("high")) == 0)
>> ? ? ? ? ? ? ? ? ? ? ? ?rdev->pm.profile = PM_PROFILE_HIGH;
>> ? ? ? ? ? ? ? ?else {
>> - ? ? ? ? ? ? ? ? ? ? ? DRM_ERROR("invalid power profile!\n");
>> + ? ? ? ? ? ? ? ? ? ? ? count = -EINVAL;
>
> I think this does not match kernel coding style (braces).
This is not 100% your fault of course, someone put this not proper
style here earlier. Maybe just worth fixing by the way.
--
Rafa?
