On Tue, May 05, 2026 at 07:50:03AM -0700, Jeff Johnson wrote:
> On 5/5/2026 7:27 AM, Jeff Johnson wrote:
> > On 5/4/2026 6:06 AM, Sumit Garg wrote:
> >> @@ -485,9 +485,9 @@ static void ath12k_ahb_power_down(struct ath12k_base
> >> *ab, bool is_suspend)
> >> pasid = (u32_encode_bits(ab_ahb->userpd_id,
> >> ATH12K_USERPD_ID_MASK)) |
> >> ATH12K_AHB_UPD_SWID;
> >> /* Release the firmware */
> >> - ret = qcom_scm_pas_shutdown(pasid);
> >> + ret = qcom_pas_shutdown(pasid);
> >> if (ret)
> >> - ath12k_err(ab, "scm pas shutdown failed for userPD%d\n",
> >> + ath12k_err(ab, "pas shutdown failed for userPD%d: %d\n",
> >> ab_ahb->userpd_id);
> >
> > at some point the "ret" param was dropped, and this now generates build
> > warnings
> The 'ret' param was dropped by:
> 8fb66931fe31 ("wifi: ath12k: Enable IPQ5424 WiFi device support")
>
> Not sure if that was on purpose or accidental. Sowmiya?
>
> - if (ret)
> - ath12k_err(ab, "scm pas shutdown failed for userPD%d: %d\n",
> - ab_ahb->userpd_id, ret);
> ...
> + if (ret)
> + ath12k_err(ab, "scm pas shutdown failed for
> userPD%d\n",
> + ab_ahb->userpd_id);
>
Ah I see, not sure why I didn't see any build issues in the defconfig
builds. Maybe this driver isn't enabled there?
Anyhow I can add the "ret" back here.
-Sumit
