On Mon, Jun 27, 2011 at 3:32 PM, Jean Delvare wrote: > * print_hex_dump_bytes() already includes a log level, so we shouldn't > ?add one. That log level is KERN_DEBUG so use the same for our header > ?for consistency. > * print_hex_dump_bytes() properly puts a newline at the end of the > ?last line, so there is no reason why we would add another one. > > Signed-off-by: Jean Delvare <khali at linux-fr.org> > Cc: David Airlie <airlied at linux.ie>
Please also consider the alternative patch I posted here a week ago: http://lists.freedesktop.org/archives/dri-devel/2011-June/012264.html It preserves KERN_ERR, however it does not remove the extra newline. Cheers, Tormod
