On Fri, 2026-03-13 at 21:12 +0000, Cavitt, Jonathan wrote: > -----Original Message----- > From: Intel-gfx <[email protected]> On Behalf > Of Jouni Högander > Sent: Friday, March 13, 2026 5:22 AM > To: [email protected]; [email protected] > Cc: [email protected]; Hogander, Jouni > <[email protected]> > Subject: [PATCH 2/2] drm/i915/psr: Disable Panel Replay on > DP_DPCD_QUIRK_NO_PANEL_REPLAY quirk > > > > Do not detect Panel Replay support if DP_DPCD_QUIRK_NO_PANEL_REPLAY > > is set > > for panel. > > > > Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/7521 > > Signed-off-by: Jouni Högander <[email protected]> > > Makes sense to me. > Reviewed-by: Jonathan Cavitt <[email protected]> > -Jonathan Cavitt
Thank you Jonathan for your review here. Unfortunately we observed using panel OUI is applying it also on devices where Panel Replay is working fine. Seems different panel models may have same OUI and Device id. In this case OUI is 00-22-b9 and dev-ID Balsa2 in both panels. I have sent new patch and added you as CC when sending: https://patchwork.freedesktop.org/series/163347/ BR, Jouni Högander > > > --- > > drivers/gpu/drm/i915/display/intel_psr.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c > > b/drivers/gpu/drm/i915/display/intel_psr.c > > index 5041a5a138d1..a62e0bd10f39 100644 > > --- a/drivers/gpu/drm/i915/display/intel_psr.c > > +++ b/drivers/gpu/drm/i915/display/intel_psr.c > > @@ -609,6 +609,12 @@ static void _panel_replay_init_dpcd(struct > > intel_dp *intel_dp, struct intel_conn > > if (intel_dp->mst_detect == DRM_DP_MST) > > return; > > > > + if (drm_dp_has_quirk(&intel_dp->desc, > > DP_DPCD_QUIRK_NO_PANEL_REPLAY)) { > > + drm_dbg_kms(display->drm, > > + "Panel Replay support not currently > > available for this panel\n"); > > + return; > > + } > > + > > ret = drm_dp_dpcd_read_data(&intel_dp->aux, > > DP_PANEL_REPLAY_CAP_SUPPORT, > > &connector- > > >dp.panel_replay_caps.dpcd, > > sizeof(connector- > > >dp.panel_replay_caps.dpcd)); > > -- > > 2.43.0 > > > >
