On 2/28/26 11:24 PM, David Lechner wrote: > On 2/28/26 10:45 PM, David Lechner wrote: >> On 2/24/26 9:24 AM, Thomas Zimmermann wrote: >>> Replace simple-display helpers with regular atomic helpers. Store the >>> pipeline elements in struct st7586_device and initialize them as part >>> of probing the device. Use mipi-dbi's existing helpers and initializer >>> macros where possible. >>> >>> Effectively open-codes the modesetting code in the initializer helpers >>> of mipi-dbi and simple-display. St7586 requires custom helpers for >>> various pipeline elements, and non-freeing cleanup of the pipeline. >>> >>> Signed-off-by: Thomas Zimmermann <[email protected]> >>> --- >> >> This results in a couple of unused variable warnings, but otherwise seems >> to still work. >> >> Tested-by: David Lechner <[email protected]> >> >> >> /home/david/work/bl/linux/drivers/gpu/drm/sitronix/st7586.c: In function >> ‘st7586_pipe_enable’: >> /home/david/work/bl/linux/drivers/gpu/drm/sitronix/st7586.c:180:25: warning: >> unused variable ‘rect’ [-Wunused-variable] >> 180 | struct drm_rect rect = { >> | ^~~~ >> /home/david/work/bl/linux/drivers/gpu/drm/sitronix/st7586.c:177:40: warning: >> unused variable ‘shadow_plane_state’ [-Wunused-variable] >> 177 | struct drm_shadow_plane_state *shadow_plane_state = >> to_drm_shadow_plane_state(plane_state); >> | ^~~~~~~~~~~~~~~~~~ >> > > Actually, I messed up and didn't notice a merge conflict with [1] when > applying the patches. So I only tested all of the patches before this > one. This means the unused variables are caused by [PATCH 01/16] > ("drm/mipi-dbi: Only modify planes on enabled CRTCs"). > It's getting late, so I'm going to stop now because I keep messing up.
This time, I forgot the link and explanation of [1]. I tested st7586 first without this series to make sure it was working to begin with. I found a bug and sent a fix for it. The fix caused the merge conflict when applying this series on top of it. I tested this series without the fix just to be sure I didn't introduce a problem in my conflict resolution. [1]: https://lore.kernel.org/dri-devel/20260228-drm-mipi-dbi-fix-st7586-byte-swap-v1-1-e78f6c24c...@baylibre.com/
