On 1/16/2026 4:45 AM, Dmitry Baryshkov wrote:
On Thu, Jan 15, 2026 at 04:28:49PM +0800, Jianping Li wrote:
From: Ekansh Gupta <[email protected]>
The initially allocated memory is not properly included in the pool,
leading to potential issues with memory management. The issue is
Define "properly" and be more explicit about "potential issues". Please
be more precise in commit messages.
By “properly” I mean that the initially allocated buffer is supposed to
be added into the Audio PD memory pool by setting pageslen accordingly.
With pageslen = 0, this buffer is never registered and therefore never
becomes part of the pool.
I will drop the vague wording and describe the exact problem.
actually a memory leak because the initial memory is never used by
Why is it not used?
Because pageslen = 0 indicates that no pages are provided.
As a result, Audio PD immediately issues a remote heap request, ignoring
the initially allocated memory entirely.
That initial buffer becomes unreachable and is effectively leaked.
Audio PD. It will immediately make a remote heap request as no memory is
Ok, you've described one issue. Beforehand it was "issues". Are there
any others? if not, please drop the "potential issues" part.
There are no additional issues beyond the memory leak caused by the
unused initial buffer.
I will remove the “potential issues” phrasing and state explicitly that
the problem is a memory leak due to the initial buffer never being added
to the pool.
added to the pool initially. Set the number of pages to one to ensure
that the initially allocated memory is correctly added to the Audio PD
memory pool.
Fixes: 0871561055e66 ("misc: fastrpc: Add support for audiopd")
Cc: [email protected]
Co-developed-by: Ekansh Gupta <[email protected]>
Signed-off-by: Ekansh Gupta <[email protected]>
Signed-off-by: Jianping Li <[email protected]>
---
drivers/misc/fastrpc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
The patch LGTM.
