On Wed, Dec 24, 2025 at 10:21:16PM +0100, Osama Abdelkader wrote: > The drm_warn() calls in the default cases of various switch statements > in xe_vm.c were missing trailing newlines, which can cause log messages > to be concatenated with subsequent output. Add '\n' to all affected > messages.
As the lines state, not possible... but well, if the messages exist, let's ensure that if that end up happening it doesn't get concatenated. pushed to drm-xe-next. Thanks for the patch. > > Signed-off-by: Osama Abdelkader <[email protected]> > --- > drivers/gpu/drm/xe/xe_vm.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c > index 79ab6c512d3e..1349dbc6f0ab 100644 > --- a/drivers/gpu/drm/xe/xe_vm.c > +++ b/drivers/gpu/drm/xe/xe_vm.c > @@ -2187,7 +2187,7 @@ static void print_op(struct xe_device *xe, struct > drm_gpuva_op *op) > (ULL)xe_vma_start(vma), (ULL)xe_vma_size(vma)); > break; > default: > - drm_warn(&xe->drm, "NOT POSSIBLE"); > + drm_warn(&xe->drm, "NOT POSSIBLE\n"); > } > } > #else > @@ -2283,7 +2283,7 @@ vm_bind_ioctl_ops_create(struct xe_vm *vm, struct > xe_vma_ops *vops, > xe_bo_unlock(bo); > break; > default: > - drm_warn(&vm->xe->drm, "NOT POSSIBLE"); > + drm_warn(&vm->xe->drm, "NOT POSSIBLE\n"); > ops = ERR_PTR(-EINVAL); > } > if (IS_ERR(ops)) > @@ -2552,7 +2552,7 @@ static int xe_vma_op_commit(struct xe_vm *vm, struct > xe_vma_op *op) > op->flags |= XE_VMA_OP_COMMITTED; > break; > default: > - drm_warn(&vm->xe->drm, "NOT POSSIBLE"); > + drm_warn(&vm->xe->drm, "NOT POSSIBLE\n"); > } > > return err; > @@ -2750,7 +2750,7 @@ static int vm_bind_ioctl_ops_parse(struct xe_vm *vm, > struct drm_gpuva_ops *ops, > > break; > default: > - drm_warn(&vm->xe->drm, "NOT POSSIBLE"); > + drm_warn(&vm->xe->drm, "NOT POSSIBLE\n"); > } > > err = xe_vma_op_commit(vm, op); > @@ -2812,7 +2812,7 @@ static void xe_vma_op_unwind(struct xe_vm *vm, struct > xe_vma_op *op, > /* Nothing to do */ > break; > default: > - drm_warn(&vm->xe->drm, "NOT POSSIBLE"); > + drm_warn(&vm->xe->drm, "NOT POSSIBLE\n"); > } > } > > @@ -2989,7 +2989,7 @@ static int op_lock_and_prep(struct drm_exec *exec, > struct xe_vm *vm, > break; > } > default: > - drm_warn(&vm->xe->drm, "NOT POSSIBLE"); > + drm_warn(&vm->xe->drm, "NOT POSSIBLE\n"); > } > > return err; > @@ -3228,7 +3228,7 @@ static void op_add_ufence(struct xe_vm *vm, struct > xe_vma_op *op, > vma_add_ufence(gpuva_to_vma(op->base.prefetch.va), ufence); > break; > default: > - drm_warn(&vm->xe->drm, "NOT POSSIBLE"); > + drm_warn(&vm->xe->drm, "NOT POSSIBLE\n"); > } > } > > -- > 2.43.0 >
