On Wed, 17 Dec 2025 15:25:40 +0100 "Luca Ceresoli" <[email protected]> wrote:
> On Thu Dec 11, 2025 at 5:38 PM CET, Kory Maincent (TI.com) wrote: > > The tilcdc driver previously supported a sub-module system where > > external display drivers (panels, encoders) could register themselves > > through tilcdc_module_init() and be automatically initialized through > > a module list. This infrastructure became unused after the component > > framework support and panel driver was removed. > > > > Signed-off-by: Kory Maincent (TI.com) <[email protected]> > > [...] > > > @@ -562,24 +533,7 @@ static struct platform_driver tilcdc_platform_driver = > > { .of_match_table = tilcdc_of_match, > > }, > > }; > > - > > -static int __init tilcdc_drm_init(void) > > -{ > > - if (drm_firmware_drivers_only()) > > - return -ENODEV; > > - > > - DBG("init"); > > - return platform_driver_register(&tilcdc_platform_driver); > > -} > > - > > -static void __exit tilcdc_drm_fini(void) > > -{ > > - DBG("fini"); > > - platform_driver_unregister(&tilcdc_platform_driver); > > -} > > - > > -module_init(tilcdc_drm_init); > > -module_exit(tilcdc_drm_fini); > > +module_platform_driver(tilcdc_platform_driver); > > Is this hunk related to the removal of the module list? Looks like it > should be a separate patch. Indeed it is not directly related, but a following cleanup. I will put it in another patch. > > With that hunk removed (or kept if I'm wrong and it should stay): > Reviewed-by: Luca Ceresoli <[email protected]> -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com
