On Sat, Jan 03, 2026 at 03:36:44PM +0000, Joel Fernandes wrote: > > On Jan 3, 2026, at 7:58 AM, Andy Shevchenko > > <[email protected]> wrote: > > On Fri, Jan 02, 2026 at 07:50:59PM -0500, Joel Fernandes wrote: > >> On Mon, Dec 29, 2025 at 11:17:48AM -0500, Steven Rostedt wrote:
... > >> I use trace_printk() all the time for kernel, particularly RCU development. > >> One of the key usecases I have is dumping traces on panic (with panic on > >> warn > >> and stop tracing on warn enabled). This is extremely useful since I can add > >> custom tracing and dump traces when rare conditions occur. I fixed several > >> bugs with this technique. > >> > >> I also recommend keeping it convenient to use. > > > > Okay, you know C, please share your opinion what header is the best to hold > > the > > trace_printk.h to be included. > > I do not think it is necessary to move it. I'm not talking about move, I'm talking about the C 101 thingy. Any custom API should be included before use, otherwise compiler won't see it. Which header do you want to include to have this API being provided? Note, it's really bad situation right now with the header to be included implicitly via non-obvious or obscure path. The discussion moved as far as I see it towards the finding a good place for the trace_printk.h. -- With Best Regards, Andy Shevchenko
