On 02/01/2026 10:29, Ayushi Makhija wrote: > On 12/27/2025 4:43 PM, Krzysztof Kozlowski wrote: >> On Thu, Dec 25, 2025 at 08:51:30PM +0530, Ayushi Makhija wrote: >>> The QCS8300 MDSS DSI PHY is the same 5nm PHY IP as on SA8775P, with >>> identical register layout and programming model. Model this by using >>> a QCS8300 specific compatible with a qcom,sa8775p-dsi-phy-5nm fallback, >>> and update the schema to require this two entry form for QCS8300 while >>> keeping existing single compatible users valid. >> >> Last sentence is redundant. I asked to explain the hardware, not to tell >> us how Devicetree works. Write concise and informative commit msgs which >> tell non-obvious things. Not what you did. I alreaded asked this - do >> not state the obvious, do not copy the subject. >> >> The only useful part of your commit msg is first sentence - two lines, >> so 33%. Remaining four lines, so 66%, is obvious. >> >> Best regards, >> Krzysztof >> > > Hi Krzysztof, > > Can you please check below commit description is it appropriate ? > > QCS8300 uses the same 5nm MDSS DSI PHY IP as SA8775P, sharing an identical > register layout and programming model. Introduce a QCS8300-specific compatible > with a fallback to `qcom,sa8775p-dsi-phy-5nm` to reflect this hardware reuse. >
Yes, that's very good. Best regards, Krzysztof
