On Wed Oct 29, 2025 at 3:37 PM CET, Louis Chauvet wrote:
> To emulate some HDR features of displays, it is required to expose some
> properties on HDMI, eDP and DP connectors.
>
> Signed-off-by: Louis Chauvet <[email protected]>

> --- a/drivers/gpu/drm/vkms/vkms_config.h
> +++ b/drivers/gpu/drm/vkms/vkms_config.h

> @@ -241,6 +246,31 @@ struct vkms_config *vkms_config_default_create(bool 
> enable_cursor,
>   */
>  void vkms_config_destroy(struct vkms_config *config);
>
> +/**
> + * vkms_config_connector_set_supported_colorspaces() - Set the supported 
> colorspaces for a connector
> + * @connector_cfg: Connector configuration to modify
> + * @supported_colorspaces: Bitmask of supported colorspaces 
> (DRM_COLOR_YCBCR_*)
                                                                ^^^^^^^^^^^^^^^^

You're dealing with colorpsaces, so this should be DRM_MODE_COLORIMETRY_*.

> + */
> +static inline void
> +vkms_config_connector_set_supported_colorspaces(struct vkms_config_connector 
> *connector_cfg,
> +                                             u32 supported_colorspaces)
> +{
> +     connector_cfg->supported_colorspaces = supported_colorspaces;
> +}
> +
> +/**
> + * vkms_config_connector_get_supported_colorspaces() - Get the supported 
> colorspaces for a connector
> + * @connector_cfg: Connector configuration to query
> + *
> + * Returns:
> + * Bitmask of supported colorspaces (DRM_COLOR_YCBCR_*)

Same here.

With those fixed you can add:

 Reviewed-by: Luca Ceresoli <[email protected]>

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Reply via email to