On Fri Nov 28, 2025 at 3:14 PM CET, Alice Ryhl wrote: > In the previous commit we updated drm_gpuvm_bo_obtain_prealloc() to take > locks internally, which means that it's only usable in immediate mode. > In this commit, we notice that drm_gpuvm_bo_obtain() requires you to use > staged mode. This means that we now have one variant of obtain for each > mode you might use gpuvm in. > > To reflect this information, we add a warning about using it in > immediate mode, and to make the distinction clearer we rename the method > with a _locked() suffix so that it's clear that it requires the caller > to take the locks. > > Signed-off-by: Alice Ryhl <[email protected]>
Ultimately, the two different approaches of obtaining a VM_BO have always been desinged for the two different modes of operation -- great to see this refined! Given that, I think it would be great to update the "Locking" section of the GPUVM's documentation and expand it with a new section "Modes of Operation". Mind sending a follow-up patch / series for this?
