On 11/27/25 4:21 PM, Petri Karhula via B4 Relay wrote:
> From: Petri Karhula <[email protected]>
>
> This driver provides backlight brightness control through the Linux
> backlight subsystem. It communicates with the board controller to
> adjust LCD backlight using PWM signals. Communication is done
> through Congatec Board Controller core driver.
>
[...]
> + bl_data->current_brightness = reply_buf[0] & BLT_PWM_DUTY_MASK;
> +
> + /* Verify the setting was applied correctly */
> + if (bl_data->current_brightness != brightness) {
> + dev_err(bl_data->dev,
> + "Brightness setting verification failed\n");
> + return -EIO;
> + }
I'm still not really convinced by other error messages, but okay let's
keep them. Maybe add current and requested brightnesses in this message,
it could be useful for debugging.
"Brightness setting verification failed (X instead of Y)"
Otherwise looks good to me. I will test your series
Reviewed-by: Thomas Richard <[email protected]>
Best Regards,
Thomas
