The usage of DCN30 CM helper creates some unexpected shimmer points on PQ shaper TF in the steamOS HDR color pipeline. Fix it by using the same DCN10 color mgmt helper of previous hw versions to translate plane shaper func to hw format in DCN32 hw family.
Signed-off-by: Melissa Wen <[email protected]> --- Hi, Commit a953cd8cac6b ("drm/amd/display: Fix MPCC 1DLUT programming") mentions some visible artifacts when using DCN10 CM helper on DCN32 shaper and blend LUTs. On the other hand, using DCN30 CM helper creates some shimmer points on steamOS HDR pipeline. We didn't noticed any visible artifacts so far, but I'd like to know more about what kind of artifacts were visible at the time this helper for shaper func was switched in the afore-mentioned commit for further investigation. Thanks in advance, Melissa drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c index bf19ba65d09a..a28560caa1c0 100644 --- a/drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c +++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c @@ -501,9 +501,9 @@ bool dcn32_set_mcm_luts( lut_params = &plane_state->in_shaper_func.pwl; else if (plane_state->in_shaper_func.type == TF_TYPE_DISTRIBUTED_POINTS) { // TODO: dpp_base replace - ASSERT(false); - cm3_helper_translate_curve_to_hw_format(&plane_state->in_shaper_func, - &dpp_base->shaper_params, true); + cm_helper_translate_curve_to_hw_format(plane_state->ctx, + &plane_state->in_shaper_func, + &dpp_base->shaper_params, true); lut_params = &dpp_base->shaper_params; } -- 2.51.0
