On Thu, Oct 09, 2025 at 05:44:46PM +0200, David Heidelberg wrote: > On 09/10/2025 16:26, Dmitry Baryshkov wrote: > > On Thu, Oct 09, 2025 at 03:32:22PM +0200, David Heidelberg wrote: > > > > > > > > > On 09/10/2025 15:21, Dmitry Baryshkov wrote: > > > > On Thu, Oct 09, 2025 at 10:51:31AM +0200, Konrad Dybcio wrote: > > > > > On 10/8/25 8:57 PM, Dmitry Baryshkov wrote: > > > > > > On Wed, Oct 08, 2025 at 04:05:28PM +0200, David Heidelberg via B4 > > > > > > Relay wrote: > > > > > > > From: David Heidelberg <[email protected]> > > > > > > > > > > > > > > Basic description for S6E3FC2X01 DDIC with attached panel > > > > > > > AMS641RW. > > > > > > > > > > > > > > Samsung AMS641RW is 6.41 inch, 1080x2340 pixels, 19.5:9 ratio > > > > > > > panel > > > > > > > > > > > > > > Signed-off-by: David Heidelberg <[email protected]> > > > > > > > --- > > > > > > > .../bindings/display/panel/samsung,s6e3fc2x01.yaml | 78 > > > > > > > ++++++++++++++++++++++ > > > > > > > MAINTAINERS | 5 ++ > > > > > > > 2 files changed, 83 insertions(+) > > > > > > > > > > > > > > > > > > > Please also describe, why it's not enough to use defined compatible, > > > > > > samsung,s6e3fc2x01. Why do we need a separate schema and can't use > > > > > > the > > > > > > panel-simple-dsi.yaml > > > > > > > > > > panel-simple works for 'dumb' (perhaps a harsh word for 'made with > > > > > just the in-spec DCS commands in mind') panels, but Samsungs are > > > > > widely known to require a ton of vendor magic > > > > > > > > The question is about the _schema_. I think it's fine to have a driver > > > > for a panel covered by panel-simple-dsi.yaml. > > > > > > see display/panel/samsung,amoled-mipi-dsi.yaml > > > the OLED display don't fit well, but I wouldn't mind consolidating at some > > > point, but since we know very little (no datasheets), it's hard to do for > > > now. Maybe in the future when there will be more panels schemas, we can > > > find > > > a way to consolidate into one big? > > > > I'm looking for a simple answer ATM: it doesn't fit > > panel-simple-dsi.yaml because it needs foo bar baz, which is not a part > > of that schema. > > v3 will have: > > dt-bindings: panel: Add Samsung S6E3FC2X01 DDIC with panel > > Basic description for S6E3FC2X01 DDIC with attached panel AMS641RW. > > Samsung AMS641RW is 6.41 inch, 1080x2340 pixels, 19.5:9 ratio panel > > panel-simple-dsi cannot be used because it's limited to one > power-supply, while we use three.
Perfect, thank you. If the bindings for samsumg,s6e3fc2x01 are incorrect, they should be dropped too. > > > > > Perhaps the original change was made with an "oh it just works > > > > > surely there's no drawbacks possible" attitude, as the panel > > > > > was left initialized by the bootloader -- With best wishes Dmitry
