Hi, [ Cc Ben ]
> In `nouveau_bo_move_prep`, if `nouveau_mem_map` fails, an error code > should be returned. Currently, it returns zero even if vmm addr is not > correctly mapped. > Signed-off-by: Shuhao Fu <[email protected]> > Fixes: 9ce523cc3bf2 ("drm/nouveau: separate buffer object backing memory from > nvkm structures") > --- > drivers/gpu/drm/nouveau/nouveau_bo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c > b/drivers/gpu/drm/nouveau/nouveau_bo.c > index b96f0555ca14..f26562eafffc 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_bo.c > +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c > @@ -929,7 +929,7 @@ nouveau_bo_move_prep(struct nouveau_drm *drm, struct > ttm_buffer_object *bo, > nvif_vmm_put(vmm, &old_mem->vma[1]); > nvif_vmm_put(vmm, &old_mem->vma[0]); > } > - return 0; > + return ret; LGTM. Reviewed-by: Petr Vorel <[email protected]> Kind regards, Petr
