I think this looks good, adding telemetry functionality as a node type
and in the yaml spec looks straightforward (despite some potential
naming awkwardness with the RAS module). Thanks for adding this.
Have you considered how this might work for containerized workloads?
Specifically, I think it would be best if the underlying drm_ras nodes
are only accessible for containerized workloads where the device has
been explicitly passed in. Do you know if this is handled automatically
with the existing netlink implementation? I imagine that this would be
of interest to the broader community outside of Qualcomm as well.
Also, it is worth to mention that we have a in-tree pyynl/cli.py tool that
entirely
exercises this new API, hence I hope this can be the reference code for the uAPI
usage, while we continue with the plan of introducing IGT tests and tools for
this
and adjusting the internal vendor tools to open with open source developments
and
changing them to support these flows.
I think it would be nice to see some accompanying userspace code that
makes use of this implementation to have as a reference if at all possible.
As a side note, I will be on vacation for a couple of weeks as of this
weekend and my response time will be affected.
Thanks,
Zack
