On Mon, Sep 15, 2025 at 01:28:46PM +0200, Maxime Ripard wrote:
> On Tue, Sep 02, 2025 at 10:22:12PM +0200, Laurent Pinchart wrote:
> > > > +       struct drm_bridge *bridge = drm_priv_to_bridge(s->obj);
> > > > +
> > > > +       drm_printf(p, "bridge: %s", 
> > > > drm_get_connector_type_name(bridge->type));
> > 
> > It would be nice to identify the bridge more precisely, but bridges have
> > no object ID :-/ The raw pointer may not be very useful. I wonder if we
> > should give an object ID to drm_private_obj instances, even if we don't
> > expose them to userspace. That's not a topic for this series of course.
> 
> I agree, and would have liked to have something a bit more descriptive
> indeed. But bridges have neither a name or an ID, so I couldn't come up
> with anything better :/

For debugfs we ended up printing the symbol for the bridge->funcs and
the OF node path in order to identify the bridge.

> 
> > Reviewed-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
> 
> Thanks!
> Maxime



-- 
With best wishes
Dmitry

Reply via email to