On 9/12/2025 6:39 PM, Dmitry Baryshkov wrote: > On Thu, Sep 11, 2025 at 10:55:09PM +0800, Xiangxu Yin wrote: >> Since max_dp_lanes and max_dp_link_rate are link-specific parameters, move >> their parsing from dp_panel to dp_link for better separation of concerns. >> >> Signed-off-by: Xiangxu Yin <xiangxu....@oss.qualcomm.com> > I thought that you've split all DP patches... > >> --- >> drivers/gpu/drm/msm/dp/dp_link.c | 63 +++++++++++++++++++++++++++++++ >> drivers/gpu/drm/msm/dp/dp_link.h | 4 ++ >> drivers/gpu/drm/msm/dp/dp_panel.c | 78 >> +++++---------------------------------- >> drivers/gpu/drm/msm/dp/dp_panel.h | 3 -- >> 4 files changed, 76 insertions(+), 72 deletions(-) >> >> @@ -1225,9 +1283,14 @@ struct msm_dp_link *msm_dp_link_get(struct device >> *dev, struct drm_dp_aux *aux) >> return ERR_PTR(-ENOMEM); >> >> link->aux = aux; >> + link->dev = dev; > It is only used during parsing of DT data. There is no need to store it > inside the struct. > > With that fixed: > > Reviewed-by: Dmitry Baryshkov <dmitry.barysh...@oss.qualcomm.com> >
Ack. >> >> mutex_init(&link->psm_mutex); >> msm_dp_link = &link->msm_dp_link; >> >> + ret = msm_dp_link_parse_dt(msm_dp_link); >> + if (ret) >> + return ERR_PTR(ret); >> + >> return msm_dp_link; >> }
