On Tue, Sep 09, 2025 at 06:52:44PM +0200, Iker Pedrosa wrote: > Add binding for Sitronix ST7920 display. > > Signed-off-by: Iker Pedrosa <ikerpedro...@gmail.com> > --- > .../bindings/display/sitronix,st7920.yaml | 52 > ++++++++++++++++++++++ > 1 file changed, 52 insertions(+) >
Please organize the patch documenting compatible (DT bindings) before their user. See also: https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46 ... > + reg: > + description: The chip-select number for the device on the SPI bus. Drop description, obvious/redundant. > + maxItems: 1 > + > + spi-max-frequency: > + maximum: 600000 > + I don't see how my comment about supply was addressed. You never responded, nothing explained in the changelog, nothing explained in the commit msg. > +required: > + - compatible > + - reg > + - spi-max-frequency > + > +allOf: > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > +unevaluatedProperties: false > + > +examples: > + - | > + // Example: ST7920 connected to an SPI bus Drop comment. > + #include <dt-bindings/gpio/gpio.h> > + > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + display@0 { > + compatible = "sitronix,st7920"; > + reg = <0>; > + spi-max-frequency = <600000>; > + spi-cs-high; > + }; > + }; > > -- > 2.51.0 >
