On 08.09.25 20:00, Borislav Petkov wrote: > On Mon, Sep 08, 2025 at 07:05:17PM +0200, Michel Dänzer wrote: >> These messages are primarily intended for developers, not users > > But everybody sees them! And they're flooding the console.
There's no question that dev_warn_ratelimited is wrong here, I'm just saying dev_warn_once isn't quite right either. BTW, the same arguments apply to the other dev_warn calls in evergreen_cs.c. Their conditions can be controlled by user space, so they must not generate any dmesg output by default. > And if those messages are only for developers, they better be not visible by > default but behind a CONFIG_DEBUG or a similar switch. Hence my suggestion to use a dbg variant, which isn't visible by default but can be enabled (and disabled again) at runtime. > And developers don't have every hw to test on. So you need to rely on users to > report issues to you. Because those messages probably don't fire on your hw > but someone else would hit them. And the chances are high that someone else is > a user. Then the developer needs to tell the user how to enable the debugging output and get it to them. That's pretty standard. >> (which will notice and report the corresponding user-space issues instead). > > The case due to which we're having this conversation didn't manifest itself > into anything - it was only flooding my dmesg. The message is logged if the kernel needs to fix up invalid data passed in by user space. That may have had no noticeable effect in your case, it certainly could in other cases though. -- Earthling Michel Dänzer \ GNOME / Xwayland / Mesa developer https://redhat.com \ Libre software enthusiast
