On Thu, Sep 4, 2025 at 2:14 PM Thomas Zimmermann <tzimmerm...@suse.de> wrote: > > Gma500 unnecessarily clears the framebuffer's GEM-object pointer > before calling drm_framebuffer_cleanup(). Remove this code to make > gma500 consistent with the rest of the drivers. > > The change is cosmetic, as drm_framebuffer_cleanup() does not > touch the object pointer on gma500. > > Signed-off-by: Thomas Zimmermann <tzimmerm...@suse.de>
Hi Thomas, looks good. Acked-by: Patrik Jakobsson <patrik.r.jakobs...@gmail.com> > --- > This change was first tested and submitted as part of the patch at > https://lore.kernel.org/dri-devel/20250704085541.28165-1-tzimmerm...@suse.de/ > . > It didn't get merged because it wasn't strictly required for that fix. > --- > drivers/gpu/drm/gma500/fbdev.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/gma500/fbdev.c b/drivers/gpu/drm/gma500/fbdev.c > index 4a37136f90f4..32d31e5f5f1a 100644 > --- a/drivers/gpu/drm/gma500/fbdev.c > +++ b/drivers/gpu/drm/gma500/fbdev.c > @@ -120,7 +120,6 @@ static void psb_fbdev_fb_destroy(struct fb_info *info) > drm_fb_helper_fini(fb_helper); > > drm_framebuffer_unregister_private(fb); > - fb->obj[0] = NULL; > drm_framebuffer_cleanup(fb); > kfree(fb); > > @@ -245,7 +244,6 @@ int psb_fbdev_driver_fbdev_probe(struct drm_fb_helper > *fb_helper, > > err_drm_framebuffer_unregister_private: > drm_framebuffer_unregister_private(fb); > - fb->obj[0] = NULL; > drm_framebuffer_cleanup(fb); > kfree(fb); > err_drm_gem_object_put: > -- > 2.50.1 >
