вт, 9 вер. 2025 р. о 03:57 Rob Herring <r...@kernel.org> пише: > > On Sat, Sep 06, 2025 at 04:53:33PM +0300, Svyatoslav Ryhel wrote: > > The avdd-dsi-csi-supply is CSI power supply, it has nothing to do with VI, > > like same supply is used with DSI and has nothing to do with DC. Move it > > to correct place. > > > > Signed-off-by: Svyatoslav Ryhel <clamo...@gmail.com> > > --- > > .../devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml | 3 --- > > .../devicetree/bindings/display/tegra/nvidia,tegra210-csi.yaml | 3 +++ > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git > > a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml > > b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml > > index dd67d4162884..bb138277d5e8 100644 > > --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml > > +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vi.yaml > > @@ -75,9 +75,6 @@ properties: > > ranges: > > maxItems: 1 > > > > - avdd-dsi-csi-supply: > > - description: DSI/CSI power supply. Must supply 1.2 V. > > - > > vip: > > $ref: /schemas/display/tegra/nvidia,tegra20-vip.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra210-csi.yaml > > b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra210-csi.yaml > > index fa07a40d1004..37f6129c9c92 100644 > > --- > > a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra210-csi.yaml > > +++ > > b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra210-csi.yaml > > @@ -37,6 +37,9 @@ properties: > > - const: cile > > - const: csi_tpg > > > > + avdd-dsi-csi-supply: > > + description: DSI/CSI power supply. Must supply 1.2 V. > > On further thought, why does this have 'dsi' in the name at all. If it > happens to be the same supply for DSI and CSI, that's an SoC integration > detail. The name here should be local to the module. Perhaps > 'avdd-supply' is enough? Fine to rename it as you are breaking the ABI > moving it anyways. >
Not only this supply is common for DSI and CSI, on all schematics I have seem so far input for this supply on CSI block is always called avdd-dsi-csi and supply is named accordingly. This patch aims not to rename supply, which has correct naming IMHO, but to place it in correct place - CSI, not VI as it is ATM. > Rob
