Hi Lyude, On Mon, Sep 08, 2025 at 06:04:44PM -0400, Lyude Paul wrote: > I made a very silly mistake with this commit that managed to slip by > because I forgot to mzke sure rvkms was rebased before testing my work last > - we can't do blanket implementations like this due to rust's orphan rule. >
In general, I would avoid using "I did something" to describe the issue of a previous commit in the commit log of a patch, it's less objective IMO. Could you reword this a bit? Maybe more focus on why a blanket implementation is problematic. Thanks! Regards, Boqun > The code -does- build just fine right now, but it doesn't with the ongoing > bindings for gem shmem. So, just revert this and we'll introduce a macro > for implementing AlwaysRefCounted individually for each type of gem > implementation. > > Note that we leave the IntoGEMObject since it is true that all gem objects > are refcounted, so any implementations that are added should be > implementing AlwaysRefCounted anyhow. > > This reverts commit 38cb08c3fcd3f3b1d0225dcec8ae50fab5751549. > > Signed-off-by: Lyude Paul <ly...@redhat.com> [...]
