Thanks for you review.
I have update patch v3:
https://lore.kernel.org/all/20250908063732.764289-1-wuzhongt...@huaqin.corp-partner.google.com/
On Sat, Sep 6, 2025 at 12:41 AM Doug Anderson <diand...@chromium.org> wrote:
>
> Hi,
>
> On Fri, Sep 5, 2025 at 12:51 AM Zhongtian Wu
> <wuzhongt...@huaqin.corp-partner.google.com> wrote:
> >
> > Add a few generic edp panels used by mt8189 chromebooks. For
> > BOE-NV140WUM-N44 V8.2 , the enable timing required 80ms. For
> > CSW-MNE007QB3-1, the hpd_absent timing rquired 80ms, the enable timing
> > required 50ms, the disable timing required 50ms. For CSW-MNE007QS3-6,
> > the enable timing required 50ms. For CMN-N140JCA-ELK, the enable timing
> > required 80ms and disable timing required 50ms.
>
> What makes this patch v2? I don't remember seeing a v1.
>
> Also: this has the _exact_ same subject as a patch that already
> landed. Please try to make patch subjects at least somewhat unique,
> even if it's "drm/panel-edp: Add 4 more panels needed by mt8189
> Chromebooks"
>
>
> > @@ -1949,6 +1956,7 @@ static const struct edp_panel_entry edp_panels[] = {
> > EDP_PANEL_ENTRY('B', 'O', 'E', 0x0cb6, &delay_200_500_e200,
> > "NT116WHM-N44"),
> > EDP_PANEL_ENTRY('B', 'O', 'E', 0x0cfa, &delay_200_500_e50,
> > "NV116WHM-A4D"),
> > EDP_PANEL_ENTRY('B', 'O', 'E', 0x0d73, &delay_200_500_e80,
> > "NE140WUM-N6S"),
> > + EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a6a, &delay_200_500_e80,
> > "NV140WUM-N44 V8.2"),
>
> Please sort properly. 0x0a6a definitely doesn't come after 0x0d73.
>
> Also, from the EDID I see:
>
> ASCII string: NV140WUM-N44
>
> ...it's better to use this exact string and get rid of the "V 8.2" at the end.
>
>
> > @@ -1978,6 +1986,7 @@ static const struct edp_panel_entry edp_panels[] = {
> > EDP_PANEL_ENTRY('C', 'M', 'N', 0x14d6, &delay_200_500_e80_d50,
> > "N140BGA-EA4"),
> > EDP_PANEL_ENTRY('C', 'M', 'N', 0x14e5, &delay_200_500_e80_d50,
> > "N140HGA-EA1"),
> > EDP_PANEL_ENTRY('C', 'M', 'N', 0x162b, &delay_200_500_e80_d50,
> > "N160JCE-ELL"),
> > + EDP_PANEL_ENTRY('C', 'M', 'N', 0x1441, &delay_200_500_e80_d50,
> > "N140JCA-ELK"),
>
> Please sort properly.
>
>
> > @@ -1987,6 +1996,8 @@ static const struct edp_panel_entry edp_panels[] = {
> > EDP_PANEL_ENTRY('C', 'S', 'W', 0x1104, &delay_200_500_e50,
> > "MNB601LS1-4"),
> > EDP_PANEL_ENTRY('C', 'S', 'W', 0x1448, &delay_200_500_e50,
> > "MNE007QS3-7"),
> > EDP_PANEL_ENTRY('C', 'S', 'W', 0x1457, &delay_80_500_e80_p2e200,
> > "MNE007QS3-8"),
> > + EDP_PANEL_ENTRY('C', 'S', 'W', 0x146e, &delay_80_500_e50_d50,
> > "MNE007QB3-1"),
> > + EDP_PANEL_ENTRY('C', 'S', 'W', 0x143f, &delay_200_500_e50,
> > "MNE007QS3-6"),
>
> Please sort properly.
>
> -Doug
