On Wed, Sep 3, 2025 at 11:02 PM Boris Brezillon <boris.brezil...@collabora.com> wrote: > > On Wed, 3 Sep 2025 15:55:04 -0700 > Chia-I Wu <olva...@gmail.com> wrote: > > > diff --git a/drivers/gpu/drm/panthor/Makefile > > b/drivers/gpu/drm/panthor/Makefile > > index 02db21748c125..75e92c461304b 100644 > > --- a/drivers/gpu/drm/panthor/Makefile > > +++ b/drivers/gpu/drm/panthor/Makefile > > @@ -12,4 +12,6 @@ panthor-y := \ > > panthor_mmu.o \ > > panthor_sched.o > > > > +panthor-$(CONFIG_DRM_PANTHOR_SOC_MT8196) += panthor_soc_mt8196.o > > Based on the stuff you describe (ASN hash, core mask read from an nvmem > cell, extra clks/regulators?), I don't think we need per-soc source > files and per-soc config options. If it becomes too HW specific (no > abstraction to make it SoC-agnostic), we can reconsider the per-SoC > file approach, but I believe it can all live in panthor_drv.c for now. That's about right except no extra clk/regulator is needed.
gpueb on mt8196 is yet another mcu running on its own fw. It can provide clk/regulator to panthor and no change is needed from panthor. But it can also do dvfs autonomously, in which case panthor needs to be modified to make clk/regulator/devfreq optional. I think the latter is where Nicolas Frattaroli is going and requires more invasive integration.
