Hi Janne, On Thu, Aug 28, 2025 at 04:01:29PM +0200, Janne Grunau wrote: > After discussion with the devicetree maintainers we agreed to not extend > lists with the generic compatible "apple,i2c" anymore [1]. Use > "apple,t8103-i2c" as fallback compatible as it is the SoC the driver > and bindings were written for. > > This block is compatible with t8103, so just add the new per-SoC > compatible using apple,t8103-i2c as base. > > [1]: > https://lore.kernel.org/asahi/12ab93b7-1fc2-4ce0-926e-c8141cfe8...@kernel.org/ > > Signed-off-by: Janne Grunau <j...@jannau.net>
Acked-by: Andi Shyti <andi.sh...@kernel.org> Andi > --- > .../devicetree/bindings/i2c/apple,i2c.yaml | 27 > +++++++++++++--------- > 1 file changed, 16 insertions(+), 11 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/apple,i2c.yaml > b/Documentation/devicetree/bindings/i2c/apple,i2c.yaml > index > fed3e1b8c43f67b8f5a19e5c1e046b0e17ab8017..500a965bdb7a84e4997b52e8c19dcc1a7ee0cff7 > 100644 > --- a/Documentation/devicetree/bindings/i2c/apple,i2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/apple,i2c.yaml > @@ -20,17 +20,22 @@ allOf: > > properties: > compatible: > - items: > - - enum: > - - apple,s5l8960x-i2c > - - apple,t7000-i2c > - - apple,s8000-i2c > - - apple,t8010-i2c > - - apple,t8015-i2c > - - apple,t8103-i2c > - - apple,t8112-i2c > - - apple,t6000-i2c > - - const: apple,i2c > + oneOf: > + - items: > + - const: apple,t6020-i2c > + - const: apple,t8103-i2c > + - items: > + - enum: > + # Do not add additional SoC to this list. > + - apple,s5l8960x-i2c > + - apple,t7000-i2c > + - apple,s8000-i2c > + - apple,t8010-i2c > + - apple,t8015-i2c > + - apple,t8103-i2c > + - apple,t8112-i2c > + - apple,t6000-i2c > + - const: apple,i2c > > reg: > maxItems: 1 > > -- > 2.51.0 >
