Le mardi 02 septembre 2025 à 11:35 +0200, Maxime Ripard a écrit :
> The ingenic IPU atomic_set_property implementation uses the
> deprecated
> drm_atomic_get_existing_crtc_state() helper.
>
> This hook is called during the state building process, before
> atomic_check, and thus before the states are swapped. The existing
> state
> thus points to the new state, and we can use
> drm_atomic_get_new_crtc_state() instead.
>
> Signed-off-by: Maxime Ripard <mrip...@kernel.org>
Tested it and my screen still works.
Reviewed-by: Paul Cercueil <p...@crapouillou.net>
and/or:
Tested-by: Paul Cercueil <p...@crapouillou.net>
Cheers,
-Paul
>
> ---
> To: Paul Cercueil <p...@crapouillou.net>
> Cc: linux-m...@vger.kernel.org
> ---
> drivers/gpu/drm/ingenic/ingenic-ipu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ingenic/ingenic-ipu.c
> b/drivers/gpu/drm/ingenic/ingenic-ipu.c
> index
> 26ebf424d63ec21ccee80221745c3e8bcc6b3d7f..2574a4b4d40a2c27cb212114117
> 829d9f6ab3ddb 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-ipu.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-ipu.c
> @@ -703,11 +703,11 @@ ingenic_ipu_plane_atomic_set_property(struct
> drm_plane *plane,
>
> mode_changed = val != ipu->sharpness;
> ipu->sharpness = val;
>
> if (state->crtc) {
> - crtc_state =
> drm_atomic_get_existing_crtc_state(state->state, state->crtc);
> + crtc_state = drm_atomic_get_new_crtc_state(state-
> >state, state->crtc);
> if (WARN_ON(!crtc_state))
> return -EINVAL;
>
> crtc_state->mode_changed |= mode_changed;
> }
