On 9/3/25 10:03 AM, Deucher, Alexander wrote:
[Public]
-----Original Message-----
From: Mario Limonciello <supe...@kernel.org>
Sent: Wednesday, September 3, 2025 12:53 AM
To: Antheas Kapenekakis <l...@antheas.dev>; amd-...@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org; linux-ker...@vger.kernel.org;
ph...@manjaro.org; Deucher, Alexander <alexander.deuc...@amd.com>; Koenig,
Christian <christian.koe...@amd.com>; Robert Beckett
<bob.beck...@collabora.com>
Subject: Re: [PATCH v3 6/6] drm: panel-backlight-quirks: Log applied panel
brightness quirks
On 8/29/2025 10:01 AM, Antheas Kapenekakis wrote:
On Fri, 29 Aug 2025 at 16:57, Antheas Kapenekakis <l...@antheas.dev> wrote:
Currently, when a panel brightness quirk is applied, there is no log
indicating that a quirk was applied. Unwrap the drm device on its own
and use drm_info() to log when a quirk is applied.
Suggested-by: Mario Limonciello <mario.limoncie...@amd.com>
Signed-off-by: Antheas Kapenekakis <l...@antheas.dev>
Besides the one thing you identified this looks fine to me.
Reviewed-by: Mario Limonciello <mario.limoncie...@amd.com>
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 263f15f6fdea..2a3e17d83d6e 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -3617,13 +3617,15 @@ static void update_connector_ext_caps(struct
amdgpu_dm_connector *aconnector)
struct drm_connector *conn_base;
struct amdgpu_device *adev;
struct drm_luminance_range_info *luminance_range;
+ struct drm_device *drm;
if (aconnector->bl_idx == -1 ||
aconnector->dc_link->connector_signal != SIGNAL_TYPE_EDP)
return;
conn_base = &aconnector->base;
- adev = drm_to_adev(conn_base->dev);
+ drm = conn_base->dev;
+ adev = drm_to_adev(drm);
caps = &adev->dm.backlight_caps[aconnector->bl_idx];
caps->ext_caps = &aconnector->dc_link->dpcd_sink_ext_caps;
@@ -3659,12 +3661,20 @@ static void update_connector_ext_caps(struct
amdgpu_dm_connector *aconnector)
panel_backlight_quirk =
drm_get_panel_backlight_quirk(aconnector->drm_edid);
if (!IS_ERR_OR_NULL(panel_backlight_quirk)) {
- if (panel_backlight_quirk->min_brightness)
+ if (panel_backlight_quirk->min_brightness) {
+ drm_info(drm,
+ "Applying panel backlight quirk, min_brightness:
%d\n",
+
+ panel_backlight_quirk->min_brightness);
mmm, needs a -1 here
You may as well re-order it too so that you set caps->min_input_signal and
access
it in this message.
With that fixed up, the series is:
Acked-by: Alex Deucher <alexander.deuc...@amd.com>
I've added a manual fixup for that change in the last patch and pushed
the series to drm-misc-next.
a3ae3384be770 (HEAD -> drm-misc-next, drm-misc/for-linux-next,
drm-misc/drm-misc-next) drm: panel-backlight-quirks: Log applied panel
brightness quirks
bf0365b005d9a drm: panel-backlight-quirks: Add Steam Deck brightness quirk
aef10b1138e99 drm: panel-backlight-quirks: Add brightness mask quirk
f7033fab81d82 drm: panel-backlight-quirks: Add secondary DMI match
6eee1ef9e5985 drm: panel-backlight-quirks: Convert brightness quirk to
generic structure
9931e4be11f21 drm: panel-backlight-quirks: Make EDID match optional
