On Thu, Aug 28, 2025 at 09:36:24AM +0200, Krzysztof Kozlowski wrote: > On Mon, Aug 25, 2025 at 11:34:21AM +0800, Yongxing Mou wrote: > > Add compatible string for the DisplayPort controller found on the > > Qualcomm QCS8300 SoC. > > > > The Qualcomm QCS8300 platform comes with one DisplayPort controller > > that supports 4 MST streams. > > > > Signed-off-by: Yongxing Mou <yongxing....@oss.qualcomm.com> > > --- > > .../bindings/display/msm/dp-controller.yaml | 26 > > +++++++++++++++++----- > > 1 file changed, 21 insertions(+), 5 deletions(-) > > > > diff --git > > a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > index > > 68a6fd27506fda004e53174db5bcc88a29e8d2a6..4da22a211442b7abe2dc18e769d8fd14d224eb40 > > 100644 > > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > @@ -18,6 +18,7 @@ properties: > > compatible: > > oneOf: > > - enum: > > + - qcom,qcs8300-dp > > - qcom,sa8775p-dp > > - qcom,sc7180-dp > > - qcom,sc7280-dp > > @@ -179,6 +180,7 @@ allOf: > > compatible: > > contains: > > enum: > > + - qcom,qcs8300-dp > > - qcom,sa8775p-dp > > - qcom,x1e80100-dp > > then: > > @@ -241,11 +243,25 @@ allOf: > > minItems: 5 > > maxItems: 6 > > else: > > - # Default to 2 streams MST > > - properties: > > - clocks: > > - minItems: 6 > > - maxItems: 6 > > + if: > > Please do not nest if:then:if:then. It gets unreadable very fast. > > I don't even understand why you need this. The code does not exist in > the next, either. That does not help.
I picked up the MST bindings patchset, so the code should be in linux-next soon. It already contains nested if-then-else which defines the number of MST streams available on the platform (R-B'ed by RobH). If you think that we should remove the nested if's I'd repost the bindings series first. -- With best wishes Dmitry
