On Fri, Aug 22, 2025 at 11:06:58AM +0800, Yongxing Mou wrote: > > > On 2025/8/21 18:28, Dmitry Baryshkov wrote: > > On Thu, Aug 21, 2025 at 11:35:57AM +0800, Yongxing Mou wrote: > > > Add compatible string for the DisplayPort controller found on the > > > Qualcomm QCS8300 SoC. > > > > > > The Qualcomm QCS8300 platform comes with one DisplayPort controller > > > with same base offset as SM8650. It requires new compatible string > > > because QCS8300 controller supports 4 MST streams. And 4 MST streams > > > support will be enabled as part of MST feature support. Currently, using > > > SM8650 data structure to enable SST on QCS8300 in the driver. > > > > Bindings describe the hardware. There is no point in discussing the > > driver here. > > > Thanks for point it.. "The Qualcomm QCS8300 platform comes with one > DisplayPort controller that supports 4 MST streams", do you think this > description will more appropriate?, only discusses the DP controller, not > referencing the driver or SM8650..
Yes > > > > > > Signed-off-by: Yongxing Mou <yongxing....@oss.qualcomm.com> > > > --- > > > Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 5 > > > ++++- > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > > b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > > index > > > 68a6fd27506fda004e53174db5bcc88a29e8d2a6..ac44abfdd2853393ae199387c9ae2c37e1c48f52 > > > 100644 > > > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > > @@ -18,6 +18,7 @@ properties: > > > compatible: > > > oneOf: > > > - enum: > > > + - qcom,qcs8300-dp > > > - qcom,sa8775p-dp > > > - qcom,sc7180-dp > > > - qcom,sc7280-dp > > > @@ -179,6 +180,7 @@ allOf: > > > compatible: > > > contains: > > > enum: > > > + - qcom,qcs8300-dp > > > - qcom,sa8775p-dp > > > - qcom,x1e80100-dp > > > then: > > > @@ -217,8 +219,9 @@ allOf: > > > compatible: > > > contains: > > > enum: > > > - # some of SA8775P DP controllers support 4 streams MST, > > > + # SA8775P DP0 and QCS8300 DP controllers support 4 > > > streams MST, > > > # others just 2 streams MST > > > > QCS8300 has only one DP. As such, it doesn't belong to this clause. > > > Emm,thanks, i got this point. So here need add another clause only work for > QCS8300(one DP controller with 4 streams), and i put codes before > "# Default to 2 streams MST", is this the correct place? > > - # Default to 2 streams MST > - properties: > - clocks: > - minItems: 6 > - maxItems: 6 > + if: > + properties: > + compatible: > + contains: > + enum: > + # QCS8300 only have one DP controllers support 4 typo, controller. > streams > + # MST, no second DP controller. > + -qcom,qcs8300-dp Missing whitespace, drop the "second DP controller" phrase. > + then: > + properties: > + clocks: > + minItems: 8 > + maxItems: 8 > + else: > + # Default to 2 streams MST > + properties: > + clocks: > + minItems: 6 > + maxItems: 6 > > > + - qcom,qcs8300-dp > > > - qcom,sa8775p-dp > > > then: > > > properties: > > > > > > -- > > > 2.34.1 > > > > > > -- With best wishes Dmitry
