On Wed, Aug 20, 2025 at 02:12:58PM -0300, Ariel D'Alessandro wrote: > Convert the existing text-based DT bindings for Dialog Semiconductor DA9211 > Voltage Regulators family to a YAML schema. Examples are simplified, as > these are all equal.
Also not wrapped... fix your editor to recognize how commits are written. > > Signed-off-by: Ariel D'Alessandro <ariel.dalessan...@collabora.com> > --- ... > +--- > +$id: http://devicetree.org/schemas/regulator/dlg,da9211.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: | Drop | > + Dialog Semiconductor > DA9211/DA9212/DA9213/DA9223/DA9214/DA9224/DA9215/DA9225 > + Voltage Regulator > + > +maintainers: > + - Ariel D'Alessandro <ariel.dalessan...@collabora.com> > + > +properties: > + compatible: > + enum: > + - "dlg,da9211" > + - "dlg,da9212" > + - "dlg,da9213" > + - "dlg,da9223" > + - "dlg,da9214" > + - "dlg,da9224" > + - "dlg,da9215" > + - "dlg,da9225" No quotes. I don't think this was ever tested. Also, keep it properly ordered > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + regulators: > + type: object > + additionalProperties: false > + description: | Drop | > + List of regulators provided by the device > + > + patternProperties: > + "^BUCK([A-B])$": [AB] > + type: object > + $ref: regulator.yaml# > + description: | > + Properties for a single BUCK regulator > + > + properties: > + regulator-initial-mode: > + items: > + enum: [ 1, 2, 3 ] > + description: Defined in > include/dt-bindings/regulator/dlg,da9211-regulator.h > + > + regulator-allowed-modes: > + items: > + enum: [ 1, 2, 3 ] > + description: Defined in > include/dt-bindings/regulator/dlg,da9211-regulator.h > + > + enable-gpios: > + maxItems: 1 > + description: Specify a valid GPIO for platform control of the > regulator Drop description, obvious. > + > + unevaluatedProperties: false For nested blocks this goes after $ref: regulator. > + > +required: > + - compatible > + - reg > + - interrupts > + - regulators > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/regulator/dlg,da9211-regulator.h> > + > + i2c1 { i2c > + #address-cells = <1>; > + #size-cells = <0>; > + > + da9212: da9212@68 { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Best regards, Krzysztof
