On 20-08-2025 17:34, Danilo Krummrich wrote:
On Wed Aug 20, 2025 at 1:56 PM CEST, Boris Brezillon wrote:
On Tue, 19 Aug 2025 03:27:30 +0530
Himal Prasad Ghimiray <himal.prasad.ghimi...@intel.com> wrote:
+/**
+ * struct drm_gpuvm_map_req - arguments passed to
drm_gpuvm_sm_map[_ops_create]()
+ */
+struct drm_gpuvm_map_req {
+ /**
+ * @op_map: struct drm_gpuva_op_map
Doc name doesn't match the field name.
+ */
+ struct drm_gpuva_op_map map;
Nit: not convinced map is a good name for that field, given this is a
map_req, so we now those are map-related arguments. I would probably
go for 'op'.
Indeed, thanks for catching this! I thought I was suggesting this name in a
previous version too.
True, somehow I misread your comment and changed it from op_map to map
instead of op. Will fix it.
Thanks
