On 08:52-20250815, Andrew Davis wrote:
> > This also allows for some future compatibility to be checked only
> > against a restricted set of vid/pid.
^^ See below
> > static const struct of_device_id it66121_dt_match[] = {
> > - { .compatible = "ite,it66121", &it66121_chip_info },
> > - { .compatible = "ite,it6610", &it6610_chip_info },
> > + { .compatible = "ite,it66121", &it66xx_chip_info },
> > + { .compatible = "ite,it6610", &it66xx_chip_info },
>
> If you will pass in the same data to all devices, just don't pass
> anything. Move the it66121_dt_match table up above probe, and just
> use it, no need for fetching it from i2c_get_match_data().
(rationale in commit messsage)
Yeah, I was going to do that, but this vendor has a bunch of devices and
I am not able to see all possible combinations.. so was thinking that
maybe some combination device will need different checks with a limited
vid/pid list.. just lack of public documentation makes me a bit
paranoid.
I am not tied to this that hard (it was a "meh"), so if folks feel this
can be thrown out, can respin.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5
849D 1736 249D
https://ti.com/opensource
