On 7/31/25 12:19 PM, Konrad Dybcio wrote: > On 7/25/25 10:35 AM, Neil Armstrong wrote: >> The Adreno GPU Management Unit (GMU) can also scale DDR Bandwidth along >> the Frequency and Power Domain level, but by default we leave the >> OPP core scale the interconnect ddr path. >> >> Declare the Bus Control Modules (BCMs) and the corresponding parameters >> in the GPU info struct to allow the GMU to vote for the bandwidth. >> >> Reviewed-by: Dmitry Baryshkov <dmitry.barysh...@oss.qualcomm.com> >> Signed-off-by: Neil Armstrong <neil.armstr...@linaro.org> >> --- >> Changes in v2: >> - Used proper ACV perfmode bit/freq >> - Link to v1: >> https://lore.kernel.org/r/20250721-topic-x1e80100-gpu-bwvote-v1-1-946619b0f...@linaro.org >> --- >> drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c >> b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c >> index >> 00e1afd46b81546eec03e22cda9e9a604f6f3b60..892f98b1f2ae582268adebd758437ff60456cdd5 >> 100644 >> --- a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c >> +++ b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c >> @@ -1440,6 +1440,17 @@ static const struct adreno_info a7xx_gpus[] = { >> .pwrup_reglist = &a7xx_pwrup_reglist, >> .gmu_chipid = 0x7050001, >> .gmu_cgc_mode = 0x00020202, >> + .bcms = (const struct a6xx_bcm[]) { >> + { .name = "SH0", .buswidth = 16 }, >> + { .name = "MC0", .buswidth = 4 }, >> + { >> + .name = "ACV", >> + .fixed = true, >> + .perfmode = BIT(3), >> + .perfmode_bw = 16500000, > > Reviewed-by: Konrad Dybcio <konrad.dyb...@oss.qualcomm.com>
Actually no, BIT(3) is for the CPU (OS), GPU should use BIT(2) Konrad